[libcxx-commits] [PATCH] D65225: [libc++] Implement CTAD for std::tuple

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a comment.

Looks plausible to me, but:

IMHO, please rename `std/utilities/tuple/tuple.tuple/tuple.cnstr/implicit_deduction_guides.pass.cpp` to `std/utilities/tuple/tuple.tuple/tuple.cnstr/deduct.pass.cpp` for consistency with the other CTAD tests.

The existing tests are completely missing any test cases for construction from `pair`, e.g. `std::tuple t = std::make_pair(std::ref(i), 2);` and `std::tuple t = std::pair(std::ref(i), 2);`; please add some tests involving `pair`.

The existing tests are missing any `deduct.fail.cpp`. I guess actually we don't expect `std::tuple t(random, args...)` to //ever// fail to compile; but maybe you can imagine a corner case that I haven't.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65225/new/

https://reviews.llvm.org/D65225