[libcxx-commits] [PATCH] D61139: (ABI break) Remove could-be-defaulted SMFs from `stack` and `queue` and `priority_queue`.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D61139#1479217 <https://reviews.llvm.org/D61139#1479217>, @mclow.lists wrote:

> In D61139#1479212 <https://reviews.llvm.org/D61139#1479212>, @ldionne wrote:
>
> > Could we remove the code while making sure that we keep `queue` & friends non-trivial even when the underlying container is trivial? Something like:
>
>
> [snip]
>
> > It seems like this achieves the best of both world: the implementation looks nicer, we preserve the ABI (unless you don't care), and we document the whole thing nicely. What do you think?
>
> I think we don't get any maintainability benefit; if anything, the code is now more complicated.


I somewhat agree, but what I meant is there's less code (namely we get rid of the SMFs).

I'm neutral about this change provided we don't break the ABI (otherwise my stance is obvious).


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61139/new/

https://reviews.llvm.org/D61139