[libcxx-commits] [PATCH] D58879: Implement uses-allocator (P0591R4)

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver marked 3 inline comments as done.
zoecarver added a comment.

Because of the length of the name `uses_allocator_construction_args`, some of the styles are... different. Feel free to suggest changes.



================
Comment at: include/memory:5710
+auto
+__uses_allocator_construction_args_impl(_Un1, // is pair
+                                        false_type, // uses allocator
----------------
Spacing


================
Comment at: include/tuple:1377
 _LIBCPP_NOEXCEPT_RETURN(
-    _Tp(_VSTD::get<_Idx>(_VSTD::forward<_Tuple>(__t))...)
+    _Tp(_VSTD::move(_VSTD::get<_Idx>(_VSTD::forward<_Tuple>(__t)))...)
 )
----------------
I can submit a separate patch for this. 


================
Comment at: test/std/utilities/memory/allocator.uses/allocator.uses.construction/uses_allocator_construction_args.pass.cpp:9
+
+// <memory>
+
----------------
Add synopsis comment


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58879/new/

https://reviews.llvm.org/D58879