[libcxx-commits] [PATCH] D60880: [libc++] Use COPYFILE_CLONE from the macOS copyfile(3) API to support APFS clones

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Apr 29 10:27:59 PDT 2019


ldionne abandoned this revision.
ldionne added a comment.

Ah! It turns out that `fcopyfile` does not support the `COPYFILE_CLONE` option at all:

> `COPYFILE_CLONE` Try to clone the file instead. 
>  This is a best try flag i.e. if cloning fails, fallback to copying the file. [...] Recursive copying however is supported, see below for more information. **(This is only applicable for the copyfile() function.)**

See the bit in bold. Apparently, this applies to the option as a whole, not only the last sentence.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60880/new/

https://reviews.llvm.org/D60880





More information about the libcxx-commits mailing list