[libcxx-commits] [libcxx] r359275 - Fix r359229 which tried to fix r359159...

[Richard Smith via libcxx-commits]

On Thu, 25 Apr 2019 at 22:04, Chandler Carruth via libcxx-commits
<libcxx-commits at lists.llvm.org> wrote:
>
> Author: chandlerc
> Date: Thu Apr 25 22:04:33 2019
> New Revision: 359275
>
> URL: http://llvm.org/viewvc/llvm-project?rev=359275&view=rev
> Log:
> Fix r359229 which tried to fix r359159...
>
> When r359229 added noexcept to the declaration of `~mutex`, it didn't
> add it to the definition which caused -Wimplicit-exception-spec-mismatch
> to fire. This just adapts the definition to agree with the declaration.

D'oh, thanks!

Looks like this warning is not -Werror'd by default in libc++ builds,
which is why my ninja check-libcxx didn't fail on it (and it was
otherwise lost in the warning noise from libunwind and libcxxabi
headers in my libc++ build config) :(

> Modified:
>     libcxx/trunk/src/mutex.cpp
>
> Modified: libcxx/trunk/src/mutex.cpp
> URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/src/mutex.cpp?rev=359275&r1=359274&r2=359275&view=diff
> ==============================================================================
> --- libcxx/trunk/src/mutex.cpp (original)
> +++ libcxx/trunk/src/mutex.cpp Thu Apr 25 22:04:33 2019
> @@ -19,7 +19,7 @@ const defer_lock_t  defer_lock = {};
>  const try_to_lock_t try_to_lock = {};
>  const adopt_lock_t  adopt_lock = {};
>
> -mutex::~mutex()
> +mutex::~mutex() _NOEXCEPT
>  {
>      __libcpp_mutex_destroy(&__m_);
>  }
>
>
> _______________________________________________
> libcxx-commits mailing list
> libcxx-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/libcxx-commits