[libcxx-commits] [PATCH] D61192: [libcxx] Add precondition check before calling match_results.str() in tests.

[Marshall Clow via Phabricator via libcxx-commits]

mclow.lists requested changes to this revision.
mclow.lists added a comment.
This revision now requires changes to proceed.

Thanks for this patch; but I don't think the suggested changes are what we want.
Instead of:

  assert(!m.ready() || m.str() == std::basic_string<CharT>());

I think we should just check:

  assert(!m.ready());

because that's the post-condition for the constructor.
If you agree, I can just make the changes myself.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61192/new/

https://reviews.llvm.org/D61192