[libcxx-commits] [PATCH] D61109: Remove incorrect explicit instantiation declarations for valarray

Richard Smith - zygoloid via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Apr 25 13:02:28 PDT 2019


rsmith added inline comments.


================
Comment at: src/valarray.cpp:13
 
+#if _LIBCPP_ABI_VERSION == 1
 template valarray<size_t>::valarray(size_t);
----------------
ldionne wrote:
> Can you add a comment explaining why we're doing this here?
Done, but I'm not sure why these are removed from the V2 ABI so I'm afraid it's a little vague.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61109/new/

https://reviews.llvm.org/D61109





More information about the libcxx-commits mailing list