[libcxx-commits] [PATCH] D61087: [libcxxabi] Fix build of cxa_guard.cpp on configurations with _LIBCXXABI_HAS_NO_THREADS
James Nagurne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Apr 25 11:23:03 PDT 2019
JamesNagurne added a comment.
I saw that too. Not really too thrilled with the fix itself, since it further fragments the source with directives, but it works.
I do have another question for @EricWF regarding the inclusion of unistd.h, but I should probably take that to a separate forum (though I've commented on the original review that added the inclusion).
Shall I cancel this review? This is my first so I'm just starting to learn the ropes :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61087/new/
https://reviews.llvm.org/D61087
More information about the libcxx-commits
mailing list