[libcxx-commits] [PATCH] D61123: [libc++] Set _LIBCPP_DLL_VIS on _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS in MinGW mode

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

> Contrary to MSVC, MinGW compilers wants the dllexport attribute on the declaration of an explicit template instantiation, not on the definition.

That sounds weird, I would expect an attribute on the explicit instantiation definition to work, since you don't technically need an explicit instantiation declaration to be visible in order to provide an explicit instantiation definition.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61123/new/

https://reviews.llvm.org/D61123