[libcxx-commits] [PATCH] D61087: [libcxxabi] Fix build of cxa_guard.cpp on configurations with _LIBCXXABI_HAS_NO_THREADS

[James Nagurne via Phabricator via libcxx-commits]

JamesNagurne added a comment.

This is an example of a solution, but I'm not married to the mechanisms by which the results are achieved:

- If you note the definition of CurrentImplementation on line 555, there's no path by which GlobalLock is used when _LIBCXXABI_HAS_NO_THREADS is set. Thus, we could alternatively guard the entirety of the implementation of InitByteGlobalMutex and insert a stub for the class.
- The code could use helpers that either call __libcpp_mutex_*/_libcpp_cond_* or return 0, so that the implementation of LibcppCondVar and LibcppMutex are clear of preprocessor directives.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61087/new/

https://reviews.llvm.org/D61087