[libcxx-commits] [PATCH] D60950: [libc++][test] Update some wstring_convert tests for MSVC quirks

Casey Carter via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Apr 22 06:39:37 PDT 2019


CaseyCarter added a comment.

In D60950#1474050 <https://reviews.llvm.org/D60950#1474050>, @mclow.lists wrote:

> I think you failed to paste a bit into the description of this patch (after the first sentence, before the second).


Reworded. Is that more clear?

> Does the "universal character names" stuff work on old standards? (C++11/03) and old compilers?

UCNs were in '98. '11 relaxed the restriction that a UCN could not name a member of the basic execution character set or a control character to only apply outside of string and character literals. The tests pass with clang 3.6 (the oldest I have readily available) in '03 mode, and gcc-4.9 in '11 mode. GCC won't compile the test in '03 mode due to the use of default template arguments in `<memory>` and `<string>`.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60950/new/

https://reviews.llvm.org/D60950





More information about the libcxx-commits mailing list