[libcxx-commits] [PATCH] D60537: [pstl] Do not inject execution policies into namespace ::pstl in the tests

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D60537#1471786 <https://reviews.llvm.org/D60537#1471786>, @MikeDvorskiy wrote:

> >   I don't think the pstl should include headers that are useless to all but one specific shipping vehicle of the PSTL (the standalone version)
>
> Why cannot it be lie onto high "include\pstl" (or even "pstl") level of "LLVM upstream" as a special folder, which will not be taken into libcxx and libcstd++ libraries?  (BTW, and as well the other extra functionality which is not going to be released with the next libcxx/libcstd release?, for e[ample alternative back-ends, experimental features, etc)
>  Just ignore it "extra" folders when the code are integrating into libcxx and libcstd repositories. 
>  What do you think here?


I don't think it should be necessary to subset the library when shipping it, and in fact I didn't plan on needing that for libc++. However, if all we're arguing about is the path for these headers, then we can put them into `include/pstl/internal/test_stdlib` or something similar. But let's avoid any name/path that suggests these headers are part of the public interface of the library, because they are not (that specific bit is the point I'm trying to make).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60537/new/

https://reviews.llvm.org/D60537