[libcxx-commits] [PATCH] D60537: [pstl] Do not inject execution policies into namespace ::pstl in the tests

Mikhail Dvorskiy via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Apr 18 01:56:14 PDT 2019


MikeDvorskiy requested changes to this revision.
MikeDvorskiy added a comment.
This revision now requires changes to proceed.

Louis,

I have an issue regarding the dummy stdlib headers.
Proposed location is valid only for the test. (/test/support/stdlib)

The tests is not necessary part of standalone PSTL because is not a part of implementation of PSTL.
For example, If i have an application which use  standalone pstl include "pstl/test/support/stdlib" would look strange at least.

So, I suggest moving the dummy stdlib headers into ..pstl\internal\stdlib or into ..pstl\stdlib


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60537/new/

https://reviews.llvm.org/D60537





More information about the libcxx-commits mailing list