[libcxx-commits] [PATCH] D60842: [libc++] Remove redundant conditionals for Apple platforms

[Louis Dionne via Phabricator via libcxx-commits]

ldionne created this revision.
ldionne added a reviewer: EricWF.
Herald added subscribers: libcxx-commits, dexonsmith, jkorous, christof.
Herald added a project: libc++.

In a bunch of places, we used to check whether LIBCXX_BUILDING_LIBCXXABI
is defined OR we're building for an Apple platform. This used to
be necessary in a time when Apple's build script did NOT define
LIBCXX_BUILDING_LIBCXXABI. However this is not relevant anymore
since Apple's build does define LIBCXX_BUILDING_LIBCXXABI.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D60842

Files:
  libcxx/src/exception.cpp
  libcxx/src/support/runtime/stdexcept_default.ipp
  libcxx/src/typeinfo.cpp


Index: libcxx/src/typeinfo.cpp
===================================================================
--- libcxx/src/typeinfo.cpp
+++ libcxx/src/typeinfo.cpp
@@ -45,11 +45,11 @@
 }
 #endif // _LIBCPP_ABI_MICROSOFT
 
-// FIXME: Remove __APPLE__ default here once buildit is gone.
 // FIXME: Remove the _LIBCPP_BUILDING_HAS_NO_ABI_LIBRARY configuration.
-#if (!defined(LIBCXX_BUILDING_LIBCXXABI) && !defined(LIBCXXRT) &&              \
-     !defined(__GLIBCXX__) && !defined(__APPLE__) &&                           \
-     !defined(_LIBCPP_ABI_VCRUNTIME)) ||   \
+#if (!defined(LIBCXX_BUILDING_LIBCXXABI) &&               \
+     !defined(LIBCXXRT) &&                                \
+     !defined(__GLIBCXX__) &&                             \
+     !defined(_LIBCPP_ABI_VCRUNTIME)) ||                  \
     defined(_LIBCPP_BUILDING_HAS_NO_ABI_LIBRARY)
 std::type_info::~type_info()
 {
Index: libcxx/src/support/runtime/stdexcept_default.ipp
===================================================================
--- libcxx/src/support/runtime/stdexcept_default.ipp
+++ libcxx/src/support/runtime/stdexcept_default.ipp
@@ -10,8 +10,7 @@
 
 /* For _LIBCPPABI_VERSION */
 #if !defined(_LIBCPP_BUILDING_HAS_NO_ABI_LIBRARY) &&                           \
-    (defined(LIBCXX_BUILDING_LIBCXXABI) || defined(__APPLE__) ||               \
-     defined(LIBCXXRT))
+    (defined(LIBCXX_BUILDING_LIBCXXABI) || defined(LIBCXXRT))
 #include <cxxabi.h>
 #endif
 
Index: libcxx/src/exception.cpp
===================================================================
--- libcxx/src/exception.cpp
+++ libcxx/src/exception.cpp
@@ -10,8 +10,7 @@
 #include "new"
 #include "typeinfo"
 
-#if defined(LIBCXXRT) || defined(LIBCXX_BUILDING_LIBCXXABI) || \
-  (defined(__APPLE__) && !defined(_LIBCPP_BUILDING_HAS_NO_ABI_LIBRARY))
+#if defined(LIBCXXRT) || defined(LIBCXX_BUILDING_LIBCXXABI)
   #include <cxxabi.h>
   using namespace __cxxabiv1;
   #define HAVE_DEPENDENT_EH_ABI 1


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60842.195642.patch
Type: text/x-patch
Size: 1953 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190417/5ab3fc17/attachment.bin>