[libcxx-commits] [PATCH] D57872: [CMake] Split linked libraries for shared and static libc++

Petr Hosek via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Apr 16 17:09:00 PDT 2019


phosek added a comment.

In D57872#1468600 <https://reviews.llvm.org/D57872#1468600>, @ldionne wrote:

> I think `LIBCXX_STATIC_LIBRARIES` and `LIBCXX_SHARED_LIBRARIES` would be better renamed `LIBCXX_STATIC_LIBRARY_DEPENDENCIES` and `LIBCXX_SHARED_LIBRARY_DEPENDENCIES `, or something similar. What do you think?


I've eliminated that variable altogether by following the pattern we already use for libc++abi.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57872/new/

https://reviews.llvm.org/D57872





More information about the libcxx-commits mailing list