[libcxx-commits] [PATCH] D60794: [libcxx][CMake] Add an option to include -lgcc_s in the linker script

[Petr Hosek via Phabricator via libcxx-commits]

phosek added inline comments.


================
Comment at: libcxx/test/lit.site.cfg.in:30
 config.llvm_unwinder            = @LIBCXXABI_USE_LLVM_UNWINDER@
+config.libgcc_unwinder          = "@LIBCXXABI_USE_LIBGCC_UNWINDER@"
 config.libcxx_is_linker_script  = @LIBCXX_ENABLE_ABI_LINKER_SCRIPT@
----------------
No need to wrap the value in `"` to make it a string since it's already Pythonized as bool.


================
Comment at: libcxx/utils/libcxx/test/target_info.py:263
+        # If we are using a linker script and llvm_unwinder or libgcc_unwinder
+        # is eanbled, then we don't need to explicitly link against an unwind
+        # implementation, since the linker script will take care of that for us.
----------------
s/eanbled/enabled/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60794/new/

https://reviews.llvm.org/D60794