[libcxx-commits] [PATCH] D60743: Allow building without threads in standalone builds
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Apr 16 14:50:07 PDT 2019
ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: dexonsmith.
The fact that we have to add this manually is unfortunate.
Better solution: define a CMake target representing the libc++ headers which has the right defines as part of its `INTERFACE`, and then have libc++abi link to these headers. Then have `cxx_shared`/`cxx_static` link to the headers AND to `cxxabi_<shared|static>`. Will refactor eventually, one thing at a time.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60743/new/
https://reviews.llvm.org/D60743
More information about the libcxx-commits
mailing list