[libcxx-commits] [PATCH] D60717: [libc++] Remove old workaround for buildit

[Louis Dionne via Phabricator via libcxx-commits]

ldionne created this revision.
ldionne added a reviewer: EricWF.
Herald added subscribers: libcxx-commits, dexonsmith, jkorous, christof.
Herald added a project: libc++.

I'm not sure what the problem was at the time, however I don't think
this is necessary since buildit doesn't exist anymore.

Instead of the workaround, the correct thing to do is to leave out
the get_new_handler/set_new_handler definitions from libc++ when
we're getting them from libc++abi.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D60717

Files:
  libcxx/src/new.cpp


Index: libcxx/src/new.cpp
===================================================================
--- libcxx/src/new.cpp
+++ libcxx/src/new.cpp
@@ -22,12 +22,8 @@
 #   include "support/runtime/new_handler_fallback.ipp"
 #elif defined(__GLIBCXX__)
     // nothing to do
-#else
-#   if defined(__APPLE__) && !defined(_LIBCPP_BUILDING_HAS_NO_ABI_LIBRARY)
-#       include <cxxabi.h> // FIXME: remove this once buildit is gone.
-#   else
-#       include "support/runtime/new_handler_fallback.ipp"
-#   endif
+#elif !defined(_LIBCPP_DISABLE_NEW_DELETE_DEFINITIONS)
+#   include "support/runtime/new_handler_fallback.ipp"
 #endif
 
 namespace std


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60717.195202.patch
Type: text/x-patch
Size: 638 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190415/92264de5/attachment.bin>