[libcxx-commits] [PATCH] D60491: Fix fpos requirements & cleanup

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver marked an inline comment as done.
zoecarver added inline comments.


================
Comment at: include/string:553
+        {__off_ += __off; return *this;}
+//     _LIBCPP_INLINE_VISIBILITY fpos  operator+ (streamoff __off) const
+//         {return __off + __off_;}
----------------
The overloads conflict with the plus and minus overloads for `streamoff`. I think it would be fine to use those overloads (because they will convert both sides to `streamoff`), but I am also happy to define the behavior explicitly. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60491/new/

https://reviews.llvm.org/D60491