[libcxx-commits] [PATCH] D60249: [pstl] Replace direct use of assert() with __PSTL_ASSERT

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Apr 10 10:27:33 PDT 2019


ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

LGTM, except for the nit.



================
Comment at: pstl/test/CMakeLists.txt:31
     target_link_libraries(${_target} PRIVATE pstl::ParallelSTL)
-    target_compile_definitions(${_target} PRIVATE -DPSTL_STANDALONE_TESTS)
+    target_compile_definitions(${_target} PRIVATE -DPSTL_STANDALONE_TESTS -DPSTL_USE_ASSERT)
     set_target_properties(${_target} PROPERTIES CXX_EXTENSIONS NO
----------------
Not needed anymore.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60249/new/

https://reviews.llvm.org/D60249





More information about the libcxx-commits mailing list