[libcxx-commits] [PATCH] D60368: Add bind_front function (P0356R5)

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.

I don't believe this patch implements the perfect forwarding call wrapper requirements laid out in the paper. Take a look at the `not_fn`  implementation as an example of this (perhaps even generalize it's implementation to be used here as well).



================
Comment at: include/functional:2980
+__bind_front_apply_both(_Fun&& __f,
+                        _TupleArgs&& __tuple_args, _VSTD::index_sequence<_Sz...>,
+                        _OtherArgs... __other_args)
----------------
Types don't need to be qualified. Only functions calls that potentially use ADL do.


================
Comment at: include/functional:2992
+    _Fun __f;
+    _VSTD::tuple<_BoundArgs...> __bound_args;
+
----------------
No need to quality tuple.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60368/new/

https://reviews.llvm.org/D60368