[libcxx-commits] [PATCH] D60422: Remove default parameters (P0935R0)

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: include/queue:42
 
+    queue() : queue(container_type()) {}
     explicit queue(const container_type& c);
----------------
zoecarver wrote:
> ldionne wrote:
> > We normally don't show the definition of functions in the synopsis. Also notice that this default constructor already appears above.
> Your right, guess I didn't see that. I will get rid of the added constructor. For the below constructors, would it be helpful to keep them in the synopsis because they show what the default value is? 
I think it's OK to keep the definition for the other constructors since they're one-liners, yes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60422/new/

https://reviews.llvm.org/D60422