[libcxx-commits] [PATCH] D60372: [gn] Support for building libcxxabi

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

In D60372#1458652 <https://reviews.llvm.org/D60372#1458652>, @thakis wrote:

> In D60372#1458557 <https://reviews.llvm.org/D60372#1458557>, @ldionne wrote:
>
> > In D60372#1458553 <https://reviews.llvm.org/D60372#1458553>, @thakis wrote:
> >
> > > In D60372#1458540 <https://reviews.llvm.org/D60372#1458540>, @jfb wrote:
> > >
> > > > For those without context, it would be really helpful if every GN commit had a link to documentation about what GN is, and how LLVM supports it. The initial commit <https://reviews.llvm.org/D54345> had a note, maybe the LLVM docs should have this?
> > >
> > >
> > > llvm/utils/gn/README.rst has a readme with links etc. It explicitly mentions that this build config is unsupported and that there's no expectation to keep that build up to date, as requested by ldionne.
> >
> >
> > Yup, my bad, I just spoke a little too fast.
>
>
> Can you clean the "Needs Revision" please? :)


I thought it would remove it upon resigning from the revision. I accepted the revision since there didn't seem to be a way of just removing my "request for changes". Please ignore my approval, too.


Repository:
  rCXXA libc++abi

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60372/new/

https://reviews.llvm.org/D60372