[libcxx-commits] [PATCH] D60309: [libcxx] Update gen_link_script.py to support different input and output

[Nico Weber via Phabricator via libcxx-commits]

thakis added a comment.

Looks good to me too except for the `elif not os.path.exists(args.input):` which I don't understand what it's for.



================
Comment at: libcxx/utils/gen_link_script.py:38
+    elif not os.path.exists(args.input):
+        # Rename the output so we can replace it with the script.
+        libcxx = os.path.relpath(args.input)
----------------
thakis wrote:
> The LHS didn't do this. Is this for Windows?
(unreplied)


================
Comment at: libcxx/utils/gen_link_script.py:62
-    if not os.path.islink(symlink_file):
-        print_and_exit("symlink file %s is not a symlink" % symlink_file)
-
----------------
thakis wrote:
> We're losing this error, is this intentional?
We're still losing this? I assume it's intentional, but might want to say why you're changing behavior here somewhere.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60309/new/

https://reviews.llvm.org/D60309