[libcxx-commits] [PATCH] D60309: [libcxx] Update gen_link_script.py to support different input and output

[Nico Weber via Phabricator via libcxx-commits]

thakis added a comment.

Nice! argparse makes this a lot simpler :)



================
Comment at: libcxx/utils/gen_link_script.py:7
+# This file is dual licensed under the MIT and the University of Illinois Open
+# Source Licenses. See LICENSE.TXT for details.
 #
----------------
I think the LHS license is the new license – probably want to keep the new license?


================
Comment at: libcxx/utils/gen_link_script.py:36
+        libcxx = os.readlink(args.input)
+        print libcxx
+    elif not os.path.exists(args.input):
----------------
stray debugging leftover?


================
Comment at: libcxx/utils/gen_link_script.py:38
+    elif not os.path.exists(args.input):
+        # Rename the output so we can replace it with the script.
+        libcxx = os.path.relpath(args.input)
----------------
The LHS didn't do this. Is this for Windows?


================
Comment at: libcxx/utils/gen_link_script.py:41
+        if os.path.exists(args.output):
+            os.rename(args.output, libcxx)
+    else:
----------------
Probably don't want to do this if args.dryrun


================
Comment at: libcxx/utils/gen_link_script.py:62
-    if not os.path.islink(symlink_file):
-        print_and_exit("symlink file %s is not a symlink" % symlink_file)
-
----------------
We're losing this error, is this intentional?


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60309/new/

https://reviews.llvm.org/D60309