[libcxx-commits] [PATCH] D60276: [libc++] Localize CMake code only related to the shared library

[Petr Hosek via Phabricator via libcxx-commits]

phosek added inline comments.


================
Comment at: libcxx/lib/CMakeLists.txt:321
 # after cxx builds.
 if (LIBCXX_ENABLE_SHARED AND LIBCXX_ENABLE_ABI_LINKER_SCRIPT)
   # Get the name of the ABI library and handle the case where CXXABI_LIBNAME
----------------
Have you considered moving this block into the `if(LIBCXX_ENABLE_SHARED)` above as well? AFAIK this is the only use of `LIBCXX_INTERFACE_LIBRARIES` so we might be able to eliminate that variable altogether.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60276/new/

https://reviews.llvm.org/D60276