[libcxx-commits] [PATCH] D60176: [libc++][libc++abi] Don't provide new/delete when built with ASan, HWASan or TSan

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Apr 3 14:39:29 PDT 2019


ldionne added a comment.

In D60176#1454062 <https://reviews.llvm.org/D60176#1454062>, @ldionne wrote:

> The right thing to do seems to be to provide `-DLIBCXX_ENABLE_NEW_DELETE_DEFINITIONS=OFF` when you configure libc++.


What I mean here is that I don't see the justification for hardcoding this into the sources. Similarly, I find it wrong for this to be dependent on `_LIBCPP_ABI_VCRUNTIME` and `__GLIBCXX__`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60176/new/

https://reviews.llvm.org/D60176





More information about the libcxx-commits mailing list