[libcxx-commits] [PATCH] D60173: [libc++abi] Do not share an object library to create the static/shared libraries

[Petr Hosek via Phabricator via libcxx-commits]

phosek marked an inline comment as done.
phosek added inline comments.


================
Comment at: libcxxabi/CMakeLists.txt:49
 option(LIBCXXABI_ENABLE_PEDANTIC "Compile with pedantic enabled." ON)
-option(LIBCXXABI_ENABLE_PIC "Build Position-Independent Code, even in static library" ON)
 option(LIBCXXABI_ENABLE_WERROR "Fail and stop if a warning is triggered." OFF)
----------------
ldionne wrote:
> Why are we dropping this?
AFAICT CMake automatically includes `-fPIC` for both shared and static library (I checked the generated `build.ninja` files) so this shouldn't be needed, or do you want to have an explicit option to disable `-fPIC`? If so, should there be a similar option for libunwind and libc++ as well?


Repository:
  rCXXA libc++abi

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60173/new/

https://reviews.llvm.org/D60173