[libcxx-commits] [PATCH] D59813: The other fix for equal algo

Wed Apr 3 09:40:10 PDT 2019

ldionne added a comment.

In D59813#1453466 <https://reviews.llvm.org/D59813#1453466>, @ldionne wrote:

> The tests you must run when contributing to this repository are the CMake ones. `ninja -C <build-dir> check-pstl` should pass.

To clarify -- it's entirely fine to have internal tests for your internal "fork" of PSTL and to run them. However, when contributing to the upstream repo, we expect the upstream tests to be passing.

We have the same situation for libc++ and libc++abi, where some vendors may have custom tests internally and they keep them passing. But when contributing upstream, they make sure that `check-cxx` is passing.

Repository:
  rPSTL pstl

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59813/new/

https://reviews.llvm.org/D59813