[libcxx-commits] [PATCH] D60145: libcxx: Add _LIBCPP_NODISCARD_EXT to 37 more functions

[Nico Weber via Phabricator via libcxx-commits]

thakis added a comment.

In D60145#1453181 <https://reviews.llvm.org/D60145#1453181>, @mclow.lists wrote:

> I'm a bit worried about nodiscard_extensions.pass.cpp, because `lit` by default does not show warnings; just "N warnings in tests" in the summary.


(That would apply to the previous version of the test too, right?)

lit prints this for me (note -Werror): llvm-lit: /Users/thakis/src/llvm-project/libcxx/utils/libcxx/test/config.py:167: note: Using warnings: ['-D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER', '-Wall', '-Wextra', '-Werror', '-Wuser-defined-warnings', '-Wshadow', '-Wno-unused-command-line-argument', '-Wno-attributes', '-Wno-pessimizing-move', '-Wno-c++11-extensions', '-Wno-user-defined-literals', '-Wno-noexcept-type', '-Wsign-compare', '-Wunused-variable', '-Wunused-parameter', '-Wunreachable-code']

Does that address your concern?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60145/new/

https://reviews.llvm.org/D60145