[libcxx-commits] [PATCH] D60145: libcxx: Add _LIBCPP_NODISCARD_EXT to 37 more functions

Nico Weber via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Apr 2 17:13:27 PDT 2019


thakis updated this revision to Diff 193394.
thakis marked 2 inline comments as done.
thakis retitled this revision from "libcxx: Add _LIBCPP_NODISCARD_EXT to 38 more functions" to "libcxx: Add _LIBCPP_NODISCARD_EXT to 37 more functions".
thakis edited the summary of this revision.
thakis added a comment.

Now with comprehensive tests; they even found a bug (I missed a minmax_element overload). Also, there's no std::find_first_not_of().


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60145/new/

https://reviews.llvm.org/D60145

Files:
  libcxx/docs/UsingLibcxx.rst
  libcxx/include/algorithm
  libcxx/test/libcxx/diagnostics/nodiscard_extensions.fail.cpp
  libcxx/test/libcxx/diagnostics/nodiscard_extensions.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60145.193394.patch
Type: text/x-patch
Size: 49529 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190403/eb21b5b6/attachment-0001.bin>


More information about the libcxx-commits mailing list