[libcxx-commits] [PATCH] D57872: [CMake] Split linked libraries for shared and static libc++

Petr Hosek via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Apr 2 19:51:41 PDT 2019


phosek added inline comments.


================
Comment at: libcxx/lib/CMakeLists.txt:396
   set(LIBCXX_INTERFACE_LIBRARY_NAMES)
-  foreach(lib ${LIBCXX_INTERFACE_LIBRARIES})
+  foreach(lib IN LISTS LIBCXX_INTERFACE_LIBRARIES)
     # FIXME: Handle cxxabi_static and unwind_static.
----------------
smeenai wrote:
> What does this change in practice?
Just a newer syntax, but it's not necessary for this change so removed.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57872/new/

https://reviews.llvm.org/D57872





More information about the libcxx-commits mailing list