[libcxx-commits] [PATCH] D60158: [libc++abi] Actually set POSITION_INDEPENDENT_CODE when building shared library

Phabricator via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Apr 2 17:28:00 PDT 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rL357550: [libc++abi] Actually set POSITION_INDEPENDENT_CODE when building shared library (authored by sbc, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Changed prior to commit:
  https://reviews.llvm.org/D60158?vs=193375&id=193400#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60158/new/

https://reviews.llvm.org/D60158

Files:
  libcxxabi/trunk/src/CMakeLists.txt


Index: libcxxabi/trunk/src/CMakeLists.txt
===================================================================
--- libcxxabi/trunk/src/CMakeLists.txt
+++ libcxxabi/trunk/src/CMakeLists.txt
@@ -176,7 +176,9 @@
   cxxabi_object_library(cxxabi_static_objects)
 endif()
 
-cxxabi_object_library(cxxabi_shared_objects POSITION_INDEPENDENT_CODE ON)
+cxxabi_object_library(cxxabi_shared_objects)
+set_target_properties(cxxabi_shared_objects PROPERTIES POSITION_INDEPENDENT_CODE ON)
+
 set(cxxabi_static_sources $<TARGET_OBJECTS:cxxabi_static_objects>)
 set(cxxabi_shared_sources $<TARGET_OBJECTS:cxxabi_shared_objects>)
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60158.193400.patch
Type: text/x-patch
Size: 614 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190403/30e99a54/attachment.bin>


More information about the libcxx-commits mailing list