[libcxx-commits] [PATCH] D60049: [libc++abi] Add LIBCXXABI_ENABLE_PIC cmake option

[Sam Clegg via Phabricator via libcxx-commits]

sbc100 marked an inline comment as done.
sbc100 added inline comments.


================
Comment at: libcxxabi/src/CMakeLists.txt:183
 
-cxxabi_object_library(cxxabi_shared_objects POSITION_INDEPENDENT_CODE ON)
+cxxabi_object_library(cxxabi_shared_objects)
 set(cxxabi_static_sources $<TARGET_OBJECTS:cxxabi_static_objects>)
----------------
ldionne wrote:
> This doesn't work because it's an object library. Now `libc++abi.dylib` will never be built with `-fPIC`.
I have another minor fix to this line as a separate change:  https://reviews.llvm.org/D60158.   It does seem seem to work and builds the library code with `fPIC`. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60049/new/

https://reviews.llvm.org/D60049