[libcxx-commits] [PATCH] D60158: [libc++abi] Actually set POSITION_INDEPENDENT_CODE when building shared library

[Sam Clegg via Phabricator via libcxx-commits]

sbc100 created this revision.
Herald added subscribers: libcxx-commits, christof, aheejin, mgorny.
Herald added a reviewer: EricWF.
Herald added a project: libc++.

This is a bug fix from https://reviews.llvm.org/D60005.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D60158

Files:
  libcxxabi/src/CMakeLists.txt


Index: libcxxabi/src/CMakeLists.txt
===================================================================
--- libcxxabi/src/CMakeLists.txt
+++ libcxxabi/src/CMakeLists.txt
@@ -176,7 +176,9 @@
   cxxabi_object_library(cxxabi_static_objects)
 endif()
 
-cxxabi_object_library(cxxabi_shared_objects POSITION_INDEPENDENT_CODE ON)
+cxxabi_object_library(cxxabi_shared_objects)
+set_target_properties(cxxabi_shared_objects PROPERTIES POSITION_INDEPENDENT_CODE ON)
+
 set(cxxabi_static_sources $<TARGET_OBJECTS:cxxabi_static_objects>)
 set(cxxabi_shared_sources $<TARGET_OBJECTS:cxxabi_shared_objects>)
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60158.193375.patch
Type: text/x-patch
Size: 596 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190402/fe3e2107/attachment.bin>