[libcxx-commits] [PATCH] D60145: libcxx: Add _LIBCPP_NODISCARD_EXT to 38 more functions
Marshall Clow via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Apr 2 13:48:01 PDT 2019
mclow.lists added a comment.
> The test is obviously incomplete.
Obviously.
This looks like a good start to me; modulo some spacing nits.
================
Comment at: libcxx/include/algorithm:1079
template <class _ForwardIterator1, class _ForwardIterator2, class _BinaryPredicate>
-_LIBCPP_CONSTEXPR_AFTER_CXX11 _ForwardIterator1
+_LIBCPP_CONSTEXPR_AFTER_CXX11 _ForwardIterator1
__find_first_of_ce(_ForwardIterator1 __first1, _ForwardIterator1 __last1,
----------------
What's with the added space here?
================
Comment at: libcxx/include/algorithm:1093
+_LIBCPP_NODISCARD_EXT inline
+_LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_AFTER_CXX17
_ForwardIterator1
----------------
Two spaces here? (and other places)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60145/new/
https://reviews.llvm.org/D60145
More information about the libcxx-commits
mailing list