[libcxx-commits] [PATCH] D55840: P0722R3: Implement library support for destroying delete

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.
Herald added a subscriber: dexonsmith.

In D55840#1435158 <https://reviews.llvm.org/D55840#1435158>, @EricWF wrote:

> In D55840#1434761 <https://reviews.llvm.org/D55840#1434761>, @ldionne wrote:
>
> > Please explain to me why we should have this in pre-C++20 dialects.
>
>
> My users get meaningful performance improvements with this feature, but we can't upgrade everything to C++20 just yet.


This is true for almost any C++20 feature. This isn't a reason to backport everything that we can to earlier standards. I don't want to litter the library with opt-ins like `_LIBCPP_ENABLE_DESTROYING_DELETE_EXT`, as it adds complexity and it creates more flavours of the library that we should be testing.

We're just turning in circles here since we've had that discussion before and we just disagree more fundamentally on providing extensions. Would you be willing not to tie this review to providing an extension so we can have a proper policy discussion to solve this matter once and for all?



================
Comment at: test/std/language.support/support.dynamic/destroying_delete_t.pass.cpp:5
+//
+// This file is dual licensed under the MIT and the University of Illinois Open
+// Source Licenses. See LICENSE.TXT for details.
----------------
This is the old license.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55840/new/

https://reviews.llvm.org/D55840