[libcxx-commits] [PATCH] D59839: Open fstream files in O_CLOEXEC mode when possible.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.

I'm fine with this as it only impacts Android. I'd let @EricWF give the final thumbs up since it'll probably fall on him if something goes wrong with Android :).



================
Comment at: libcxx/include/__config:1464
+// do.
+#if _LIBCPP_GLIBC_PREREQ(2, 7) || defined(__BIONIC__)
+#  define _LIBCPP_FOPEN_CLOEXEC_MODE "e"
----------------
danalbert wrote:
> ldionne wrote:
> > mclow.lists wrote:
> > > smeenai wrote:
> > > > To be clear, the plan is to limit this to Bionic and drop the glibc part, correct?
> > > That was my impression, yes.
> > I'd be fine with that. Please update the review.
> Sorry, it didn't seem anyone had actually made that decision. I was still waiting for someone to say yes or no.
No worries -- I don't think it was clear either.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59839/new/

https://reviews.llvm.org/D59839