[libcxx-commits] [PATCH] D60114: [CMake] Differentiate between static and shared libc++abi

[Jonas Hahnfeld via Phabricator via libcxx-commits]

Hahnfeld added a comment.

I guess that change makes sense overall, some comments from reading the code inline. I didn't apply the patch locally so I might be missing some context here...



================
Comment at: libcxx/cmake/Modules/HandleLibCXXABI.cmake:111
+    else()
+      set(CXXABI_SHARED_LIBNAME cxxabi_shared)
     endif()
----------------
This should be `CXXABI_STATIC_LIBNAME`, no?


================
Comment at: libcxx/lib/CMakeLists.txt:62-65
+    add_library_flags("-Wl,-force_load" "${LIBCXX_CXX_STATIC_ABI_LIBRARY}")
   else()
     add_library_flags("-Wl,--whole-archive" "-Wl,-Bstatic")
+    add_library_flags("${LIBCXX_CXX_STATIC_ABI_LIBRARY}")
----------------
`LIBCXX_CXX_SHARED_ABI_LIBRARY`?


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60114/new/

https://reviews.llvm.org/D60114