[libcxx-commits] [PATCH] D60097: Fix implementation of ::abs and std::abs LWG 2192.

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF added inline comments.


================
Comment at: test/std/language.support/support.runtime/cstdlib.pass.cpp:67
+      (std::is_same<decltype(std::abs((unsigned short)0)), int>::value), "");
+
+  assert(std::abs(-1.) == 1);
----------------
mclow.lists wrote:
> How about `signed char` here?  I don't think that there are any others we need to check.
Sure. Done.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60097/new/

https://reviews.llvm.org/D60097