[libcxx-commits] [PATCH] D60105: Fix vector<bool>::const_reference to be 'bool'.

[Marshall Clow via Phabricator via libcxx-commits]

mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.

Other than those nits, this looks fine to me.



================
Comment at: include/__config:68
 #endif
-
+#define _LIBCPP_ABI_VECTOR_BOOL_CORRECT_CONST_REFERENCE_TYPE
 #if defined(_LIBCPP_ABI_UNSTABLE) || _LIBCPP_ABI_VERSION >= 2
----------------
Is this testing detritus?


================
Comment at: test/std/containers/sequences/vector.bool/insert_iter_size_value.pass.cpp:70
+      std::vector<bool> v2;
+      v2.insert(v2.begin(), 3, cv[0]);
+    }
----------------
You should also `assert(v2.size() == 3)` and that `v[0] == cv[0]`


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60105/new/

https://reviews.llvm.org/D60105