[libcxx-commits] [PATCH] D59839: Open fstream files in O_CLOEXEC mode when possible.

[Dan Albert via Phabricator via libcxx-commits]

danalbert added a comment.

I'm not really sure who speaks for glibc platforms. @EricWF? Like I said, if we're not comfortable making this change for glibc I don't have a problem backing that out, but I do think this is a more useful default behavior. It's fairly convoluted to pass a file descriptor from an `fstream` across an `exec` boundary intentionally so I somewhat doubt anyone is doing so intentionally. Anyone doing so unintentionally is just leaking an fd and any use of it on the other side of the exec is probably a bug.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59839/new/

https://reviews.llvm.org/D59839