[libcxx] r343434 - Remove even more warnings from clang-cl build

Eric Fiselier eric at efcs.ca
Sun Sep 30 18:31:24 PDT 2018


Author: ericwf
Date: Sun Sep 30 18:31:23 2018
New Revision: 343434

URL: http://llvm.org/viewvc/llvm-project?rev=343434&view=rev
Log:
Remove even more warnings from clang-cl build

Modified:
    libcxx/trunk/CMakeLists.txt

Modified: libcxx/trunk/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/CMakeLists.txt?rev=343434&r1=343433&r2=343434&view=diff
==============================================================================
--- libcxx/trunk/CMakeLists.txt (original)
+++ libcxx/trunk/CMakeLists.txt Sun Sep 30 18:31:23 2018
@@ -50,6 +50,10 @@ MACRO_ENSURE_OUT_OF_SOURCE_BUILD(
  "${PROJECT_NAME} requires an out of source build. Please create a separate
  build directory and run 'cmake /path/to/${PROJECT_NAME} [options]' there."
  )
+if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang" AND "${CMAKE_CXX_SIMULATE_ID}" STREQUAL "MSVC")
+  message(STATUS "Configuring for clang-cl")
+  set(LIBCXX_TARGETING_CLANG_CL ON)
+endif()
 
 if (MSVC)
   set(LIBCXX_TARGETING_MSVC ON)
@@ -124,11 +128,6 @@ if (NOT LIBCXX_ENABLE_SHARED AND NOT LIB
   message(FATAL_ERROR "libc++ must be built as either a shared or static library.")
 endif()
 
-if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang" AND "${CMAKE_CXX_SIMULATE_ID}" STREQUAL "MSVC")
-  message(STATUS "Configuring for clang-cl")
-  set(LIBCXX_TARGETING_CLANG_CL ON)
-endif()
-
 # ABI Library options ---------------------------------------------------------
 set(LIBCXX_CXX_ABI "default" CACHE STRING
     "Specify C++ ABI library to use.")
@@ -556,8 +555,13 @@ if ("${CMAKE_CXX_COMPILER_ID}" MATCHES "
     if (LIBCXX_TARGETING_CLANG_CL)
       add_compile_flags_if_supported(
         -Wno-c++98-compat
+        -Wno-c++98-compat-pedantic
         -Wno-c++11-compat
         -Wno-undef
+        -Wno-reserved-id-macro
+        -Wno-gnu-include-next
+        -Wno-gcc-compat # For ignoring "'diagnose_if' is a clang extension" warnings
+        -Wno-zero-as-null-pointer-constant # FIXME: Remove this and fix all occurances.
       )
     endif()
 elseif("${CMAKE_CXX_COMPILER_ID}" MATCHES "GNU")




More information about the libcxx-commits mailing list