[PATCH] D52675: [clang] Properly apply attributes on explicit instantiations of static data members
Louis Dionne via Phabricator
reviews at reviews.llvm.org
Fri Sep 28 16:05:10 PDT 2018
ldionne created this revision.
ldionne added a reviewer: aaron.ballman.
Herald added subscribers: libcxx-commits, dexonsmith.
https://llvm.org/PR39118
Repository:
rCXX libc++
https://reviews.llvm.org/D52675
Files:
clang/lib/Sema/SemaTemplate.cpp
clang/test/SemaCXX/attr-on-explicit-template-instantiation.cpp
Index: clang/test/SemaCXX/attr-on-explicit-template-instantiation.cpp
===================================================================
--- /dev/null
+++ clang/test/SemaCXX/attr-on-explicit-template-instantiation.cpp
@@ -0,0 +1,25 @@
+// RUN: %clang_cc1 -emit-llvm %s -o - | FileCheck %s
+
+// PR39118
+// Make sure that attributes are properly applied to explicit template
+// instantiations.
+
+#define HIDDEN __attribute__((__visibility__("hidden")))
+#define VISIBLE __attribute__((__visibility__("default")))
+
+namespace ns HIDDEN {
+ struct A { };
+ template <typename T> struct B { static A a; };
+ template <typename T> A B<T>::a;
+
+ // CHECK: @_ZN2ns1BIiE1aE = weak_odr global
+ // CHECK-NOT: hidden
+ template VISIBLE A B<int>::a;
+}
+
+struct C { };
+template <typename T> struct D { static C c; };
+template <typename T> C D<T>::c;
+
+// CHECK-DAG: @_ZN1DIiE1cB3TAGE
+template __attribute__((abi_tag("TAG"))) C D<int>::c;
Index: clang/lib/Sema/SemaTemplate.cpp
===================================================================
--- clang/lib/Sema/SemaTemplate.cpp
+++ clang/lib/Sema/SemaTemplate.cpp
@@ -9173,10 +9173,8 @@
if (!HasNoEffect) {
// Instantiate static data member or variable template.
Prev->setTemplateSpecializationKind(TSK, D.getIdentifierLoc());
- if (PrevTemplate) {
- // Merge attributes.
- ProcessDeclAttributeList(S, Prev, D.getDeclSpec().getAttributes());
- }
+ // Merge attributes.
+ ProcessDeclAttributeList(S, Prev, D.getDeclSpec().getAttributes());
if (TSK == TSK_ExplicitInstantiationDefinition)
InstantiateVariableDefinition(D.getIdentifierLoc(), Prev);
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52675.167564.patch
Type: text/x-patch
Size: 1693 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20180928/647d9d19/attachment.bin>
More information about the libcxx-commits
mailing list