[PATCH] D52662: [libc++] Make sure we can build libc++ with -fvisibility=hidden

Louis Dionne via Phabricator reviews at reviews.llvm.org
Fri Sep 28 13:58:29 PDT 2018

ldionne added a comment.

In https://reviews.llvm.org/D52662#1249528, @smeenai wrote:

> It's awesome that you're looking into hidden visibility!

The gray hair I'm growing begs to disagree :-).

> I'm guessing you figured out the missing symbols by running `check-cxx` or trying to link some applications or similar?

I added `-fvisibility=hidden` to the build flags, built libc++.dylib and ran `check-cxx-abilist`. There were several missing symbols, and I added the annotations in this commit until there were no missing symbols anymore.

  rCXX libc++


More information about the libcxx-commits mailing list