[PATCH] D52368: [libc++abi] is_strcmp parameter to is_equal is unused for WIN32

Pirama Arumuga Nainar via Phabricator reviews at reviews.llvm.org
Fri Sep 21 10:31:23 PDT 2018

pirama created this revision.
pirama added reviewers: EricWF, srhines, mstorsjo.
Herald added subscribers: libcxx-commits, ldionne, christof.

Mark it as unused to avoid -Wunused-parameter.

  rCXXA libc++abi



Index: src/private_typeinfo.cpp
--- src/private_typeinfo.cpp
+++ src/private_typeinfo.cpp
@@ -51,13 +51,17 @@
 // Defining _LIBCXX_DYNAMIC_FALLBACK does not help since can_catch() calls 
 // is_equal() with use_strcmp=false so the string names are not compared.
+#define _UNUSED_IN_WIN32
 #ifdef _WIN32
 #include <string.h>
+#define _UNUSED_IN_WIN32 __attribute__((unused))
 static inline
-is_equal(const std::type_info* x, const std::type_info* y, bool use_strcmp)
+is_equal(const std::type_info* x,
+         const std::type_info* y,
+         _UNUSED_IN_WIN32 bool use_strcmp)
 #ifndef _WIN32
     if (!use_strcmp)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52368.166502.patch
Type: text/x-patch
Size: 707 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20180921/fe02f447/attachment.bin>

More information about the libcxx-commits mailing list