[PATCH] D51868: [libcxx] Build and test fixes for Windows

Hamza Sood via Phabricator reviews at reviews.llvm.org
Wed Sep 19 11:20:05 PDT 2018

hamzasood added inline comments.

Comment at: test/support/verbose_assert.h:26
   static_assert(ST == -1, "specialization required for ST != -1");
   static void Print(Tp const&) { std::clog << "Value Not Streamable!\n"; }
mclow.lists wrote:
> > The renaming is to clarify that an `stderr` stream is being selected.
> And yet, there is `clog`, right there.
I guess because that’s logging a programmer error (trying to print a type that isn’t streamable) whereas the others are test-related diagnostics? Not completely sure though.


More information about the libcxx-commits mailing list