[PATCH] D52240: Partial Fix for PR#38964
Louis Dionne via Phabricator
reviews at reviews.llvm.org
Wed Sep 19 08:39:39 PDT 2018
ldionne added a comment.
In https://reviews.llvm.org/D52240#1239448, @mclow.lists wrote:
> In https://reviews.llvm.org/D52240#1239434, @ldionne wrote:
> > Marshall, what's the error we get with GCC in C++03 mode that this patch is fixing? Is there a bug.llvm.org associated to that?
> PR#38964 (from the title) ;-)
I'm sorry -- I didn't see it.
> So these are now instantiated in the .so file. This is on FreeBSD, but I assume it will be the same on macOS and Linux; I can't check at the moment.
I don't think that correct. All the functions are marked with `_LIBCPP_INLINE_VISIBILITY`, which means they are not exported from the dylib. At least that should be true on macOS.
More information about the libcxx-commits