[PATCH] D53868: Build with -fvisibility=hidden

Louis Dionne via Phabricator reviews at reviews.llvm.org
Tue Oct 30 14:16:13 PDT 2018


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

After talking to Eric, the plan is:

1. Turn on `-fvisibility=hidden` when building
2. Apply `__attribute__((visibility("hidden")))` at namespace scope and remove the compiler flags.
3. Start moving classes to use explicit lists of exported methods with default visibility attributes instead of the huge mess we have today.

I'm fine with this, but (3) still needs some preliminary work before it can happen fully (visibility attributes are not supported perfectly even on Clang trunk).


Repository:
  rCXX libc++

https://reviews.llvm.org/D53868





More information about the libcxx-commits mailing list