[PATCH] D53879: Make libc++'s versioning namespace customizable
Louis Dionne via Phabricator
reviews at reviews.llvm.org
Tue Oct 30 13:55:29 PDT 2018
ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.
================
Comment at: CMakeLists.txt:685
+if (NOT LIBCXX_ABI_NAMESPACE STREQUAL "")
+ if (NOT LIBCXX_ABI_NAMESPACE MATCHES "__.*")
+ message(FATAL_ERROR "LIBCXX_ABI_NAMESPACE must be a reserved identifier.")
----------------
`__.+`? Or do we want to allow `__`?
Repository:
rCXX libc++
https://reviews.llvm.org/D53879
More information about the libcxx-commits
mailing list